Add config writing capability #99

Closed
cw wants to merge 3 commits from (deleted):master into master
1 changed files with 11 additions and 7 deletions
Showing only changes of commit 22db44fdb9 - Show all commits

View File

@ -1,7 +1,7 @@
use crate::sd_reader;
use core::fmt;
use alloc::{string::FromUtf8Error, string::String, vec::Vec};
use core_io::{self as io, BufRead, BufReader, Read, Write};
use core_io::{self as io, BufRead, BufReader, Read, Write, ErrorKind};
use libboard_zynq::sdio;
@ -107,19 +107,18 @@ impl Config {
pub fn write_str<'b>(&mut self, key: &str, data: &str) -> Result<'b, ()>{
if let Some(fs) = &self.fs {
let root_dir = fs.root_dir();
let mut file;
Outdated
Review

AFAICT this does not need a forward declaration.
You can just do let mut file = match... below. The mut is perhaps not needed either.

AFAICT this does not need a forward declaration. You can just do ``let mut file = match...`` below. The ``mut`` is perhaps not needed either.
Outdated
Review

If mut is not used, I get "cannot borrow as mutable" when calling truncate and write_all

If mut is not used, I get "cannot borrow as mutable" when calling truncate and write_all
let isascii_and_short = data.is_ascii() & (data.len() <= 100);
let use_config_txt = data.is_ascii() & (data.len() <= 100);
let file_path;
Outdated
Review

A better variable name would be use_config_txt.

A better variable name would be ``use_config_txt``.
let config_key_bin = &["/CONFIG/", key, ".BIN"].concat();
if isascii_and_short {
if use_config_txt {
file_path = "/CONFIG.TXT";
} else {
file_path = config_key_bin;
}
file = match root_dir.create_file(file_path) {
let mut file = match root_dir.create_file(file_path) {
Ok(f) => f,
Err(_) => root_dir.open_file("/CONFIG.TXT")?
};
@ -128,10 +127,15 @@ impl Config {
file.write_all(&[key,"="].concat().as_bytes())?;
file.write_all(data.as_bytes())?;
Outdated
Review

Why not a single file.write_all(&[key, "=", data].concat().as_bytes())? (or similar) ?
Also, won't that erase all the other keys from config.txt?

Why not a single ``file.write_all(&[key, "=", data].concat().as_bytes())?`` (or similar) ? Also, won't that erase all the other keys from ``config.txt``?
if isascii_and_short {
if use_config_txt {
match root_dir.remove(config_key_bin) {
Ok(_) => {},
Err(_) => {}
Err(e) => match e.kind() {
Outdated
Review

You could simply add a Err(ErrorKind::NotFound) branch to the main match statement...

You could simply add a ``Err(ErrorKind::NotFound)`` branch to the main ``match`` statement...
ErrorKind::NotFound => {},
Outdated
Review

You want to report errors that are not "the file doesn't exist".

You want to report errors that are not "the file doesn't exist".
_ => {
return Err(Error::IoError(e));
}
}
};
}