Kernel exception: fixed top level finally. (#70) #71

pca006132 · 2020-07-23T14:16:20+08:00

pca006132 commented

2020-07-23 14:16:20 +08:00

Fixes #70.

This is due to the exception handling code calling terminate directly after _Unwind_RaiseException returns _URC_END_OF_STACK, meaning that no exception handler for that exception is found. However, it would miss the potential cleanup routines which should be called by a forced unwind.

Libunwind does not provide a forced unwind for us, and it seems difficult to do so. This fix uses a hack, reporting handler found when it finds a cleanup routine, which would trick the unwinder to do phase two unwinding (actually calling the cleanup routines) even if no routine would catch the exception.

Fixes #70. This is due to the exception handling code calling `terminate` directly after `_Unwind_RaiseException` returns `_URC_END_OF_STACK`, meaning that no exception handler for that exception is found. However, it would miss the potential cleanup routines which should be called by a forced unwind. Libunwind does not provide a forced unwind for us, and it seems difficult to do so. This fix uses a hack, reporting handler found when it finds a cleanup routine, which would trick the unwinder to do phase two unwinding (actually calling the cleanup routines) even if no routine would catch the exception.

sb10q closed this pull request

2020-07-23 14:48:45 +08:00

Sign in to join this conversation.

No reviewers