M-Labs/artiq-zynq
10
1
Fork 20
Code Issues 13 Pull Requests Releases Wiki Activity

core1: use C repr in attribute writeback #357

Merged
sb10q merged 1 commits from srenblad/artiq-zynq:fix_attr_writeback into master 2025-02-06 20:13:26 +08:00
Conversation 0 Commits 1 Files Changed 1 +2
srenblad commented 2025-02-06 15:01:38 +08:00
Collaborator
Copy Link

Rust reserves the right to reorder struct fields if the struct is repr(Rust). The Attr and Type structs come from the compiled kernel code, and they appear to have fixed ordering in the LLVM IR.

This is not a problem for our current Rust version, as the compiler is less aggressive with field reordering. I have noticed it becoming a problem when pushing the rustc version higher.

All HITL tests pass and there are no noticeable performance changes for test_performance.py.

Rust reserves the right to reorder struct fields if the struct is `repr(Rust)`. The `Attr` and `Type` structs come from the compiled kernel code, and they [appear](https://github.com/m-labs/artiq/blob/9558dd20e1cf3aa0afcaf1acf29202350c040cdc/artiq/compiler/transforms/llvm_ir_generator.py#L566-L570) to have fixed ordering in the LLVM IR. This is not a problem for our current Rust version, as the compiler is less aggressive with field reordering. I have noticed it becoming a problem when pushing the `rustc` version higher. All HITL tests pass and there are no noticeable performance changes for `test_performance.py`.
👍 1
srenblad added 1 commit 2025-02-06 15:01:38 +08:00
sb10q merged commit 21a4a0b5dd into master 2025-02-06 20:13:26 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#357
No description provided.
Delete Branch "srenblad/artiq-zynq:fix_attr_writeback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?