bump rustc, llvm #348

srenblad · 2024-12-20T17:44:00+08:00

srenblad commented

2024-12-20 17:44:00 +08:00

Bumps to 1.56.0-nightly (29ef6cf16 2021-08-31) and LLVM13.

Tested on Kasli-SoC in standalone and master-satellite configs with basic blinky. MonInj tested in master-sat. Analyzer tested on standalone.

Ran HITL tests for standalone, no issues. Performance tests are comparable to before bump.

Bumps to 1.56.0-nightly (29ef6cf16 2021-08-31) and LLVM13. Tested on Kasli-SoC in standalone and master-satellite configs with basic blinky. MonInj tested in master-sat. Analyzer tested on standalone. Ran HITL tests for standalone, no issues. Performance tests are comparable to before bump.

srenblad added 11 commits 2024-12-20 17:44:00 +08:00

change to C-unwind interface 8f510b5ca6

replace const_in_array_expression with inline ffe3020788

replace deprecated NoneError use 7d6d40a785

prevent cursor r/w optimization 81eba30a29

llvm11 -> llvm13 16801a35f4

use forked core_io, up nalgebra 0021a01bdf

remove unused abi-blacklist, force-unwind-tables 97e15d51f2

silence inline_const warns 8d07f006f2

update cargo lockfile 13264d9992

flake add outputHashes 7acf8af7f7

update dependencies 8fd8cae9d5

sb10q reviewed 2024-12-21 09:30:40 +08:00

src/libio/cursor.rs

						
				@ -59,6 +61,7 @@ impl Write for Cursor<&mut [u8]> {

				        let data = &mut self.inner[self.pos..];

				        let len = buf.len().min(data.len());

				        for i in 0..len {

				            unsafe { asm!("", options(preserves_flags, nostack, readonly)); }

sb10q commented

2024-12-21 09:30:40 +08:00

I think we can get rid of this hack altogether since memory is copied elsewhere when accessing the DRTIO aux buffers?
But this could be another PR.

I think we can get rid of this hack altogether since memory is copied elsewhere when accessing the DRTIO aux buffers? But this could be another PR.

👍 1

sb10q commented

2024-12-21 09:31:35 +08:00

Are subkernels tested?

mwojcik reviewed 2024-12-23 07:09:31 +08:00

src/libboard_artiq/Cargo.toml.tpl

						
				@ -21,3 +21,3 @@

				log_buffer = { version = "1.2" }

				crc = { version = "1.7", default-features = false }

				core_io = { version = "0.1", features = ["collections"] }

				core_io = { git = "https://git.m-labs.hk/M-Labs/rs-core_io.git", rev = "e9d3edf027", features = ["collections"] }

mwojcik commented

2024-12-23 07:09:31 +08:00

What does that patch do?

srenblad commented

2024-12-23 09:35:54 +08:00

core_io is unmaintained and locked to the rustc versions already supported due to how the repo is maintained using scripts and patches from std::io. It is probably the biggest blocker for bumping the rust version, due to also being a dependency of rust-fatfs in zynq-rs.

`core_io` is unmaintained and locked to the rustc versions already supported due to how the repo is maintained using scripts and patches from `std::io`. It is probably the biggest blocker for bumping the rust version, due to also being a dependency of `rust-fatfs` in `zynq-rs`.

👍 1