M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

Fix DWARF parser treating catch blocks as unconditional #339

Merged
sb10q merged 1 commits from jcoates/artiq-zynq:jjc/fix-eh-type into master 2024-11-20 09:32:39 +08:00
Conversation 2 Commits 1 Files Changed 1 +1 -4
jcoates commented 2024-11-20 01:20:47 +08:00
Contributor
Copy Link

get_ttype_entry incorrectly uses a match expression, causing v to be bound to a ttype_base, rather than checking if the two are equal. This means that any catch block is treated as having no exception ID filter, and so unconditionally matches.

Fixes https://github.com/m-labs/artiq/issues/2108.

`get_ttype_entry` incorrectly uses a `match` expression, causing `v` to be bound to a `ttype_base`, rather than checking if the two are equal. This means that any `catch` block is treated as having no exception ID filter, and so unconditionally matches. Fixes https://github.com/m-labs/artiq/issues/2108.
jcoates added 1 commit 2024-11-20 01:20:47 +08:00 
Signed-off-by: Jonathan Coates <jonathan.coates@oxionics.com>
jcoates force-pushed jjc/fix-eh-type from a9ec4d55c3 to 2c7138797d 2024-11-20 01:21:21 +08:00 Compare
sb10q requested review from occheung 2024-11-20 08:00:01 +08:00
sb10q requested review from dpn 2024-11-20 08:00:01 +08:00
dpn commented 2024-11-20 09:21:07 +08:00
Collaborator
Copy Link

LGTM – it's pretty clearly a typo, and treating literal zeros as 0 in an otherwise pc-relative table is indeed required (I have a similar patch for upstream ARTIQ on x86_64 as part of my on-host core device emulator branch that I need to get around to upstreaming).

LGTM – it's pretty clearly a typo, and treating literal zeros as 0 in an otherwise pc-relative table is indeed required (I have a similar patch for upstream ARTIQ on x86_64 [as part of my on-host core device emulator branch](https://github.com/dnadlinger/artiq/commit/3d0bad2dbe1839589881ecdcad1728f95a39e392) that I need to get around to upstreaming).
sb10q merged commit 1d431456f4 into master 2024-11-20 09:32:39 +08:00
sb10q commented 2024-11-20 10:25:37 +08:00
Owner
Copy Link

Breaks tests.
https://nixbld.m-labs.hk/build/170009/nixlog/2

Breaks tests. https://nixbld.m-labs.hk/build/170009/nixlog/2
jcoates deleted branch jjc/fix-eh-type 2024-11-20 18:36:44 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
occheung
dpn
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#339
No description provided.
Delete Branch "jcoates/artiq-zynq:jjc/fix-eh-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?