kernel/api: add nalgebra::linalg methods #308

abdul124 · 2024-07-22T11:37:08+08:00

abdul124 commented

2024-07-22 11:37:08 +08:00

(Requires #307)
Adds the nalgebra::linalg methods to the runtime.

(Requires #307) Adds the `nalgebra::linalg` methods to the runtime.

sb10q reviewed 2024-07-22 11:44:48 +08:00

src/libksupport/src/kernel/api.rs Outdated

						
				@ -41,0 +57,4 @@

				    let data_slice = slice::from_raw_parts_mut(data, dim0 * dim1);

				    let matrix = DMatrix::from_row_slice(dim0, dim1, data_slice);

				    assert!(matrix[(0, 1)] == matrix[(1, 0)], "Wilkinson Shift is defined for 2D symmetric matrices");

sb10q commented

2024-07-22 11:44:48 +08:00

I don't think crashing the firmware in response to incorrect user input is a sensible thing to do.

sb10q commented

2024-07-22 11:45:06 +08:00

And isn't this check expensive?

abdul124 commented

2024-07-22 11:55:20 +08:00

I can move this check to nac3core during code generation. The function can work under the assumption that the received input is of correct type (Other checks like having square matrix for linalg_try_invert_to or having a 2x2 matrix for linalg_wilkinson_shift are implemented in this manner).

I can move this check to nac3core during code generation. The function can work under the assumption that the received input is of correct type (Other checks like having square matrix for `linalg_try_invert_to` or having a 2x2 matrix for `linalg_wilkinson_shift` are implemented in this manner).

sb10q commented

2024-07-22 11:55:49 +08:00

OK.

abdul124 commented

2024-07-22 11:58:44 +08:00

Revised