aux: increase max payload size #298

Merged
sb10q merged 1 commits from mwojcik/artiq-zynq:drtioaux_bigger_packet into master 2024-05-20 15:20:07 +08:00
Owner

Zynq equivalent of artiq#2404. Thankfully no shenanigans with Rust toolchain were necessary, so this can stay on the older version (postponing the pain, when we finally migrate the code to the main repo...).

Turns out that the work buffer isn't necessary, writer/reader can work, just not with copy_from_slice, that probably generates AXI bursts. No need to align/pad access in packet fields either.

Zynq equivalent of [artiq#2404](https://github.com/m-labs/artiq/pull/2404). Thankfully no shenanigans with Rust toolchain were necessary, so this can stay on the older version (postponing the pain, when we finally migrate the code to the main repo...). Turns out that the work buffer isn't necessary, writer/reader can work, just not with ``copy_from_slice``, that probably generates AXI bursts. No need to align/pad access in packet fields either.
mwojcik added 1 commit 2024-05-17 15:34:20 +08:00
esavkin reviewed 2024-05-17 16:06:50 +08:00
@ -83,2 +80,2 @@
let mut buf: [u8; LEN] = [0; LEN];
copy_work_buffer(ptr, buf.as_mut_ptr() as *mut u32, LEN as isize);
let len = Packet::get_aligned_size(*(ptr as *mut u8));
let mut buf: [u8; 1024] = [0; 1024];
Owner

Wouldn't it be better to move 1024 out to some constant?

Wouldn't it be better to move `1024` out to some constant?
mwojcik force-pushed drtioaux_bigger_packet from fa6fc1cee9 to 6ce7959d7d 2024-05-20 14:00:20 +08:00 Compare
sb10q merged commit 2b2ebb5354 into master 2024-05-20 15:20:07 +08:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#298
No description provided.