M-Labs
/
artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

fix #228 and initialize io_dir setting at io_expander.rs #257

Merged
sb10q merged 2 commits from morgan/artiq-zynq:bugfix_pinswap into release-7 2023-09-04 15:50:45 +08:00
Conversation 1 Commits 2 Files Changed 4 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dd7cb4be6f - Show all commits

2
src/runtime/src/main.rs
View File

@ -128,7 +128,7 @@ pub fn main_core0() {
io_expander1 io_expander1
.init(i2c_bus) .init(i2c_bus)
.expect("I2C I/O expander #1 initialization failed"); .expect("I2C I/O expander #1 initialization failed");
// Actively drive TX_DISABLE to false on SFP0..3 // Drive TX_DISABLE to false on SFP0..3
io_expander0.set(0, 1, false); io_expander0.set(0, 1, false);
io_expander1.set(0, 1, false); io_expander1.set(0, 1, false);
io_expander0.set(1, 1, false); io_expander0.set(1, 1, false);

2
src/satman/src/main.rs
View File

@ -483,7 +483,7 @@ pub extern fn main_core0() -> i32 {
io_expander1 io_expander1
.init(&mut i2c) .init(&mut i2c)
.expect("I2C I/O expander #1 initialization failed"); .expect("I2C I/O expander #1 initialization failed");
// Actively drive TX_DISABLE to false on SFP0..3 // Drive TX_DISABLE to false on SFP0..3
morgan marked this conversation as resolved Outdated
sb10q commented 2023-09-04 14:29:39 +08:00
Outdated
Review
Copy Link

"Actively" comment becomes misleading since the code it refers to no longer touches OE.

"Actively" comment becomes misleading since the code it refers to no longer touches OE.
io_expander0.set(0, 1, false); io_expander0.set(0, 1, false);
io_expander1.set(0, 1, false); io_expander1.set(0, 1, false);
io_expander0.set(1, 1, false); io_expander0.set(1, 1, false);