M-Labs/artiq-zynq
10
1
Fork 20
Code Issues 13 Pull Requests 1 Releases Wiki Activity

use csr::virtual_leds for SFP0..3 LED indication #244

Merged
sb10q merged 10 commits from morgan/artiq-zynq:feature into master 2023-08-28 16:08:11 +08:00
Conversation 0 Commits 10 Files Changed 4 +3 -3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f917c62948 - Show all commits

2
src/runtime/src/main.rs
View File

@ -122,7 +122,7 @@ async fn async_rtio_led() {
let i2c1 = unsafe { (&mut i2c::I2C_BUS).as_mut().unwrap() }; let i2c1 = unsafe { (&mut i2c::I2C_BUS).as_mut().unwrap() };
let mut io_expander0 = io_expander::IoExpander::new(i2c0, 0).unwrap(); let mut io_expander0 = io_expander::IoExpander::new(i2c0, 0).unwrap();
sb10q commented 2023-08-02 17:48:13 +08:00
Outdated
Review
Copy Link

It's confusing to create IO expander objects, which also should be singletons and do more than controlling LEDs, into a function whose name indicates it is about LEDs.

It's confusing to create IO expander objects, which also should be singletons and do more than controlling LEDs, into a function whose name indicates it is about LEDs.
sb10q commented 2023-08-04 15:53:53 +08:00
Outdated
Review
Copy Link

As I told you before, those I/O expander objects should be created only once in the entire firmware.

Additionally, you create them once with i2c::I2C_BUS and once with &mut *i2c_ptr, which is inconsistent.

As I told you before, those I/O expander objects should be created only once in the entire firmware. Additionally, you create them once with ``i2c::I2C_BUS`` and once with ``&mut *i2c_ptr``, which is inconsistent.
let mut io_expander1 = io_expander::IoExpander::new(i2c1, 1).unwrap(); let mut io_expander1 = io_expander::IoExpander::new(i2c1, 1).unwrap();
loop{ loop {
morgan marked this conversation as resolved Outdated
sb10q commented 2023-08-04 15:42:28 +08:00
Outdated
Review
Copy Link

Just inline it.

 block_async!(|| {
   let current = unsafe { pl::csr::virtual_leds::status_read() };
   ...
Just inline it. ``` block_async!(|| { let current = unsafe { pl::csr::virtual_leds::status_read() }; ... ```
let _ = block_async!(wait_for_virtual_leds_change()).await; let _ = block_async!(wait_for_virtual_leds_change()).await;
info!("switching"); info!("switching");
morgan marked this conversation as resolved Outdated
mwojcik commented 2023-08-01 16:32:15 +08:00
Outdated
Review
Copy Link

Debug leftover? Remove pls

Debug leftover? Remove pls
io_expander0.service().expect("I2C I/O expander #0 service failed"); io_expander0.service().expect("I2C I/O expander #0 service failed");