release-7: backport add SFP0..3 LED indication #243

Closed
morgan wants to merge 1 commits from morgan:backport-feature into release-7

Back-porting SFP0..3 LED indication (#242) to release-7

Back-porting SFP0..3 LED indication (#242) to release-7
morgan added 1 commit 2023-07-27 12:47:44 +08:00
sb10q reviewed 2023-07-27 14:00:04 +08:00
@ -93,0 +100,4 @@
let len: usize = pl::csr::DRTIO.len();
READ_RTIO_LED = 0;
for linkno in 0..len {
//let linkno = linkno as usize;

Remove

Remove
sb10q reviewed 2023-07-27 14:05:06 +08:00
@ -93,0 +117,4 @@
unsafe {
let i2c = (&mut i2c::I2C_BUS).as_mut().unwrap();
for expander_i in 0..=1 {
let mut io_expander = io_expander::IoExpander::new(i2c, expander_i).unwrap();

Move out of the loop. Generally, follow the main ARTIQ repos.

Move out of the loop. Generally, follow the main ARTIQ repos.
sb10q reviewed 2023-07-27 14:06:21 +08:00
@ -13,0 +14,4 @@
const IO_DIR_INPUT_ALL: u8 = 0xFF;
const IO_DIR_OUT_SFP_TX_DISABLE: u8 = !0x02;
const IO_DIR_OUT_SFP_LED: u8 = !0x40;
//SFP0 LED has different place in v1.1

That is obvious from the code already. Remove.

That is obvious from the code already. Remove.

Code in master is still messy and needs to be sorted out first.

Code in master is still messy and needs to be sorted out first.
sb10q closed this pull request 2023-08-02 17:50:52 +08:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#243
There is no content yet.