M-Labs
/
artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

Fix mismatched signatures for the wide interface #229

Merged
sb10q merged 1 commits from jcoates/artiq-zynq:fix-wide-interface into master 2023-04-17 09:24:31 +08:00
Conversation 2 Commits 1 Files Changed 2 +2 -2
jcoates commented 2023-04-13 00:06:18 +08:00
Contributor
Copy Link

See #76.

Lists are passed by-reference from python code, and so should be &CSlice<_> not CSlice<_>. This change was made for the cache already in ae0d724bf8, but not for the wide interface.

A quick grep for extern.*CSlice suggests these are the only remaining functions with a mismatched signature.

See #76. Lists are passed by-reference from python code, and so should be `&CSlice<_>` not `CSlice<_>`. This change was made for the cache already in ae0d724bf802d17b67e2032e00abb83d2ff79b66, but not for the wide interface. A quick grep for `extern.*CSlice` suggests these are the only remaining functions with a mismatched signature.
jcoates added 1 commit 2023-04-13 00:06:18 +08:00
2a4e00375c Fix mismatched signatures for the wide interface 
Lists are passed by-reference from python code, and so should be
&CSlice<_> not CSlice<_>.
sb10q commented 2023-04-13 09:08:53 +08:00
Owner
Copy Link

Seems to make sense. Did you actually test this?

Seems to make sense. Did you actually test this?
jcoates commented 2023-04-13 17:30:20 +08:00
Author
Contributor
Copy Link

Yes - connected an oscciliscope to a fastino and can confirm it produces the right voltages both using DMA and writing events directly.

There are still some other issues with using the wide interface (we're seeing a lot of RTIO collision errors), but I'm not sure if that's a Kasli-SoC specific issue. I want to test on Kasli 2.0 before reporting anything.

Yes - connected an oscciliscope to a fastino and can confirm it produces the right voltages both using DMA and writing events directly. There are still some other issues with using the wide interface (we're seeing a lot of RTIO collision errors), but I'm not sure if that's a Kasli-SoC specific issue. I want to test on Kasli 2.0 before reporting anything.
sb10q merged commit 8cb6cf6094 into master 2023-04-17 09:24:31 +08:00
jcoates deleted branch fix-wide-interface 2023-06-08 22:54:44 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#229
No description provided.
Delete Branch "jcoates/artiq-zynq:fix-wide-interface"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?