Moninj: fix working with DRTIO #190

mwojcik · 2022-05-25T10:54:36+08:00

mwojcik commented

2022-05-25 10:54:36 +08:00

Closes #189

Few things came with this issue:

nested block that caused original panic -> drtio moninj is now async
minor: timeout check would be too early because initial check would be at 0ms -> next check is now at get_time()
with satellite disconnected moninj would send a lot messages w/ aqctl proxy and dashboard (all channels monitored/injected) -> link down error demoted to debug
with satellite connected it would cause a deadlock and hang the device -> had to add an async way to locking the mutex, so other coroutines would still have a chance of finishing
minor: drtio would still try to send a packet even if the link was down (for what?)

Now I have tested it with and without satellite connected and the device is responsive and does not spam the logs anymore.

Closes #189 Few things came with this issue: - nested block that caused original panic -> drtio moninj is now async - minor: timeout check would be too early because initial check would be at 0ms -> next check is now at ``get_time()`` - with satellite disconnected moninj would send *a lot* messages w/ aqctl proxy and dashboard (all channels monitored/injected) -> link down error demoted to debug - with satellite connected it would cause a deadlock and hang the device -> had to add an async way to locking the mutex, so other coroutines would still have a chance of finishing - minor: drtio would still try to send a packet even if the link was down (for what?) Now I have tested it with and without satellite connected and the device is responsive and does not spam the logs anymore.

mwojcik added 5 commits 2022-05-25 10:54:36 +08:00

48c9b43171 moninj: make it use async drtioaux

24df52268e moninj: restructure timeout

stop logging errors if satellite is unavailable
drtio: don't even send message if link is down

4f457d9c24 moninj: log link down at debug level

596edb480c cargo: update zynq-rs

7a8f96dbd9 rtio_mgt: use mutex's async_lock

sb10q merged commit 7a8f96dbd9 into master

2022-05-25 12:17:24 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#190