M-Labs
/
artiq-zynq
9
1
Fork 16
Code Issues 13 Pull Requests 1 Releases Wiki Activity

Moninj: fix working with DRTIO #190

Merged
sb10q merged 5 commits from mwojcik/artiq-zynq:moninj_async into master 2022-05-25 12:17:24 +08:00
Conversation 0 Commits 5 Files Changed 4
mwojcik commented 2022-05-25 10:54:36 +08:00
Owner

Closes #189

Few things came with this issue:

  • nested block that caused original panic -> drtio moninj is now async
  • minor: timeout check would be too early because initial check would be at 0ms -> next check is now at get_time()
  • with satellite disconnected moninj would send a lot messages w/ aqctl proxy and dashboard (all channels monitored/injected) -> link down error demoted to debug
  • with satellite connected it would cause a deadlock and hang the device -> had to add an async way to locking the mutex, so other coroutines would still have a chance of finishing
  • minor: drtio would still try to send a packet even if the link was down (for what?)

Now I have tested it with and without satellite connected and the device is responsive and does not spam the logs anymore.

Closes #189 Few things came with this issue: - nested block that caused original panic -> drtio moninj is now async - minor: timeout check would be too early because initial check would be at 0ms -> next check is now at ``get_time()`` - with satellite disconnected moninj would send *a lot* messages w/ aqctl proxy and dashboard (all channels monitored/injected) -> link down error demoted to debug - with satellite connected it would cause a deadlock and hang the device -> had to add an async way to locking the mutex, so other coroutines would still have a chance of finishing - minor: drtio would still try to send a packet even if the link was down (for what?) Now I have tested it with and without satellite connected and the device is responsive and does not spam the logs anymore.
mwojcik added 5 commits 2022-05-25 10:54:36 +08:00
24df52268e moninj: restructure timeout 
stop logging errors if satellite is unavailable
drtio: don't even send message if link is down
sb10q merged commit 7a8f96dbd9 into master 2022-05-25 12:17:24 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical
   
priority:high
   
priority:low
   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#190
There is no content yet.
Delete Branch "mwojcik/artiq-zynq:moninj_async"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?