backporting "Host report for async error upon kernel termination" #156

Merged
sb10q merged 4 commits from stevefan1999/artiq-zynq:master into master 12 months ago

backport of 4a6bea479a

backport of https://github.com/m-labs/artiq/commit/4a6bea479af03bca5a3583977bbdebf4c7f6b14e
stevefan1999 added 2 commits 12 months ago
sb10q reviewed 12 months ago
StartRequest,
KernelFinished,
KernelException(&'static eh_artiq::Exception<'static>, &'static [usize]),
KernelFinished {
Owner

Keep it on one line like the others. It's not special.

Keep it on one line like the others. It's not special.
stevefan1999 marked this conversation as resolved
Owner

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Not really a "backport", eventually this firmware will replace the one in ARTIQ. Have you tested it thoroughly?
stevefan1999 added 1 commit 12 months ago
Poster

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.

> Not really a "backport", eventually this firmware will replace the one in ARTIQ. > Have you tested it thoroughly? Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.
stevefan1999 added 1 commit 12 months ago
Owner

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq?

Yes.

> Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? Yes.
sb10q merged commit 84becfe2c0 into master 12 months ago
The pull request has been merged as 84becfe2c0.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.