M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests 1 Releases Wiki Activity

backporting "Host report for async error upon kernel termination" #156

Merged
sb10q merged 4 commits from stevefan1999/artiq-zynq:master into master 2021-12-06 17:38:55 +08:00
Conversation 3 Commits 4 Files Changed 4 +19 -7
stevefan1999 commented 2021-12-06 15:04:01 +08:00
Contributor
Copy Link

backport of 4a6bea479a

backport of https://github.com/m-labs/artiq/commit/4a6bea479af03bca5a3583977bbdebf4c7f6b14e
stevefan1999 added 2 commits 2021-12-06 15:04:02 +08:00
sb10q reviewed 2021-12-06 15:11:47 +08:00
src/runtime/src/kernel/mod.rs Outdated
@ -32,3 +32,2 @@
StartRequest,
KernelFinished,
KernelException(&'static eh_artiq::Exception<'static>, &'static [usize]),
KernelFinished {
sb10q commented 2021-12-06 15:11:47 +08:00
Owner
Copy Link

Keep it on one line like the others. It's not special.

Keep it on one line like the others. It's not special.
stevefan1999 marked this conversation as resolved
sb10q commented 2021-12-06 15:12:20 +08:00
Owner
Copy Link

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Not really a "backport", eventually this firmware will replace the one in ARTIQ. Have you tested it thoroughly?
stevefan1999 added 1 commit 2021-12-06 15:23:37 +08:00
stevefan1999 commented 2021-12-06 16:11:32 +08:00
Author
Contributor
Copy Link

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.

> Not really a "backport", eventually this firmware will replace the one in ARTIQ. > Have you tested it thoroughly? Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.
stevefan1999 added 1 commit 2021-12-06 16:23:30 +08:00
sb10q commented 2021-12-06 17:38:18 +08:00
Owner
Copy Link

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq?

Yes.

> Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? Yes.
sb10q merged commit 84becfe2c0 into master 2021-12-06 17:38:55 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#156
No description provided.
Delete Branch "stevefan1999/artiq-zynq:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?