M-Labs
/
artiq-zynq
12
0
Fork 15
Code Issues 12 Pull Requests 1 Releases Wiki Activity

Labels Milestones

backporting "Host report for async error upon kernel termination" #156

Merged
sb10q merged 4 commits from stevefan1999/artiq-zynq:master into master 2 years ago
Conversation 3 Commits 4 Files Changed 4
stevefan1999 commented 2 years ago

backport of 4a6bea479a

backport of https://github.com/m-labs/artiq/commit/4a6bea479af03bca5a3583977bbdebf4c7f6b14e
stevefan1999 added 2 commits 2 years ago
sb10q reviewed 2 years ago
src/runtime/src/kernel/mod.rs Outdated
@ -32,3 +32,2 @@
StartRequest,
KernelFinished,
KernelException(&'static eh_artiq::Exception<'static>, &'static [usize]),
KernelFinished {
sb10q commented 2 years ago
Owner

Keep it on one line like the others. It's not special.

Keep it on one line like the others. It's not special.
stevefan1999 marked this conversation as resolved
sb10q commented 2 years ago
Owner

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Not really a "backport", eventually this firmware will replace the one in ARTIQ. Have you tested it thoroughly?
stevefan1999 added 1 commit 2 years ago
stevefan1999 commented 2 years ago
Poster

Not really a "backport", eventually this firmware will replace the one in ARTIQ.
Have you tested it thoroughly?

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.

> Not really a "backport", eventually this firmware will replace the one in ARTIQ. > Have you tested it thoroughly? Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? If yes, then I'd say lgtm.
stevefan1999 added 1 commit 2 years ago
sb10q commented 2 years ago
Owner

Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq?

Yes.

> Is it okay to just use the test suites from artiq master branch and run it using the default-provided device db of Zynq? Yes.
sb10q merged commit 84becfe2c0 into master 2 years ago
sb10q referenced this issue from a commit 2 years ago
report async errors upon kernel termination
The pull request has been merged as 84becfe2c0.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b stevefan1999-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff stevefan1999-master
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
priority:critical
   
priority:high
   
priority:low
   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#156
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'stevefan1999/artiq-zynq:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes