M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests 1 Releases Wiki Activity

117_rtio_channels #147

Merged
sb10q merged 10 commits from mwojcik/artiq-zynq:117_rtio_channels into master 2021-10-13 17:20:25 +08:00
Conversation 0 Commits 10 Files Changed 1 +78 -10
mwojcik commented 2021-10-13 16:06:16 +08:00
Owner
Copy Link

made two by mistake

made two by mistake
mwojcik added 7 commits 2021-10-13 16:06:17 +08:00
mwojcik closed this pull request 2021-10-13 16:07:19 +08:00
sb10q reviewed 2021-10-13 16:07:21 +08:00
src/gateware/zc706.py Outdated
@ -461,0 +501,4 @@
self.submodules += phy
rtio_channels.append(rtio.Channel.from_phy(phy, ififo_depth=512))
# could check the LED #
sb10q commented 2021-10-13 16:07:21 +08:00
Owner
Copy Link

What does this mean?

What does this mean?
mwojcik commented 2021-10-13 16:15:32 +08:00
Author
Owner
Copy Link

I was wondering if the exact LED that gets controlled on board really matters. The index 2 of the user LED here was copied from kc705, maybe a different one would be any better?

I was wondering if the exact LED that gets controlled on board really matters. The index 2 of the user LED here was copied from kc705, maybe a different one would be any better?
sb10q commented 2021-10-13 16:16:55 +08:00
Owner
Copy Link

Can't recall why it's 2 on KC705. I suggest using the same LED index as in the former Simple target.

Can't recall why it's 2 on KC705. I suggest using the same LED index as in the former Simple target.
mwojcik commented 2021-10-13 16:25:20 +08:00
Author
Owner
Copy Link

Former Simple target used all of them:

src/gateware/zc706.py Line 510 in ab0c205dd2
phy = ttl_simple.Output(platform.request("user_led_33", i))

Former Simple target used all of them: https://git.m-labs.hk/M-Labs/artiq-zynq/src/commit/ab0c205dd23c8baa7070053e7f53cfa81e1755ed/src/gateware/zc706.py#L510
sb10q commented 2021-10-13 16:25:49 +08:00
Owner
Copy Link

Okay, then the example kernel used 0 :)

Okay, then the example kernel used 0 :)
sb10q reviewed 2021-10-13 16:07:26 +08:00
local_run.sh Outdated
@ -59,4 +59,3 @@
fi
artiq_netboot $load_bitstream_cmd -f $result_dir/$fwtype.bin -b $board_host
fi
sb10q commented 2021-10-13 16:07:26 +08:00
Owner
Copy Link

weird

weird
mwojcik commented 2021-10-13 16:18:12 +08:00
Author
Owner
Copy Link

true, not sure where that came from, popped up after updating the branch (merging master in)

true, not sure where that came from, popped up after updating the branch (merging master in)
mwojcik reopened this pull request 2021-10-13 16:13:15 +08:00
mwojcik added 1 commit 2021-10-13 16:14:16 +08:00
mwojcik added 1 commit 2021-10-13 16:36:09 +08:00
sb10q merged commit 5c40115945 into master 2021-10-13 17:20:25 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#147
No description provided.
Delete Branch "mwojcik/artiq-zynq:117_rtio_channels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?