117_rtio_channels #147

Merged
sb10q merged 10 commits from mwojcik/artiq-zynq:117_rtio_channels into master 1 year ago
mwojcik commented 1 year ago
Owner

made two by mistake

made two by mistake
mwojcik added 7 commits 1 year ago
mwojcik closed this pull request 1 year ago
sb10q reviewed 1 year ago
self.submodules += phy
rtio_channels.append(rtio.Channel.from_phy(phy, ififo_depth=512))
# could check the LED #
sb10q commented 1 year ago
Owner

What does this mean?

What does this mean?
mwojcik commented 1 year ago
Poster
Owner

I was wondering if the exact LED that gets controlled on board really matters. The index 2 of the user LED here was copied from kc705, maybe a different one would be any better?

I was wondering if the exact LED that gets controlled on board really matters. The index 2 of the user LED here was copied from kc705, maybe a different one would be any better?
sb10q commented 1 year ago
Owner

Can't recall why it's 2 on KC705. I suggest using the same LED index as in the former Simple target.

Can't recall why it's 2 on KC705. I suggest using the same LED index as in the former Simple target.
mwojcik commented 1 year ago
Poster
Owner

Former Simple target used all of them: ab0c205dd2/src/gateware/zc706.py (L510)

Former Simple target used all of them: https://git.m-labs.hk/M-Labs/artiq-zynq/src/commit/ab0c205dd23c8baa7070053e7f53cfa81e1755ed/src/gateware/zc706.py#L510
sb10q commented 1 year ago
Owner

Okay, then the example kernel used 0 :)

Okay, then the example kernel used 0 :)
sb10q reviewed 1 year ago
local_run.sh Outdated
fi
artiq_netboot $load_bitstream_cmd -f $result_dir/$fwtype.bin -b $board_host
fi
sb10q commented 1 year ago
Owner

weird

weird
mwojcik commented 1 year ago
Poster
Owner

true, not sure where that came from, popped up after updating the branch (merging master in)

true, not sure where that came from, popped up after updating the branch (merging master in)
mwojcik reopened this pull request 1 year ago
mwojcik added 1 commit 1 year ago
mwojcik added 1 commit 1 year ago
sb10q merged commit 5c40115945 into master 1 year ago
The pull request has been merged as 5c40115945.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.