added explicit runtime/satman targets for makefile #144

mwojcik · 2021-10-08T17:24:02+08:00

mwojcik commented

2021-10-08 17:24:02 +08:00

As discussed in #135.

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

As discussed in #135. Unfortunately they cannot be called simply runtime/satman as it collides with what ``find`` finds.

mwojcik added 1 commit 2021-10-08 17:24:02 +08:00

added explicit runtime/satman targets for makefile b0259bcc39

sb10q commented

2021-10-08 20:21:16 +08:00

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

> Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. Why is that an issue at all with phony targets? Additionally, ``find`` should only look at the source directory, not the ``target`` directory.

sb10q commented

2021-10-08 20:22:09 +08:00

The README also needs an update about using the satman target when building for a satellite.

mwojcik commented

2021-10-08 20:29:45 +08:00

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

find in the makefile is ran from artiq-zynq/src, and adds all files in src, including runtime and satman folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix.

Will update the README in a moment.

> > Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. > > Why is that an issue at all with phony targets? > Additionally, ``find`` should only look at the source directory, not the ``target`` directory. find in the makefile is ran from artiq-zynq/src, and adds all files in src, including ``runtime`` and ``satman`` folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix. Will update the README in a moment.

sb10q commented

2021-10-08 20:31:01 +08:00

find -type f ?

``find -type f`` ?

👍 1

sb10q commented

2021-10-08 20:31:43 +08:00

Directories should not have been included anyway.

mwojcik added 1 commit 2021-10-08 20:37:17 +08:00

find to print only files no dirs, removed suffix f24b76502a

mwojcik added 1 commit 2021-10-08 20:38:55 +08:00

Merge branch 'master' into make_explicit_targets d947c06e33