M-Labs
/
artiq-zynq
9
1
Fork 16
Code Issues 13 Pull Requests 1 Releases Wiki Activity

added explicit runtime/satman targets for makefile #144

Merged
sb10q merged 4 commits from mwojcik/artiq-zynq:make_explicit_targets into master 2021-10-08 21:06:23 +08:00
Conversation 5 Commits 4 Files Changed 3
mwojcik commented 2021-10-08 17:24:02 +08:00
Owner

As discussed in #135.

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

As discussed in #135. Unfortunately they cannot be called simply runtime/satman as it collides with what ``find`` finds.
mwojcik added 1 commit 2021-10-08 17:24:02 +08:00
sb10q commented 2021-10-08 20:21:16 +08:00
Owner

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

> Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. Why is that an issue at all with phony targets? Additionally, ``find`` should only look at the source directory, not the ``target`` directory.
sb10q commented 2021-10-08 20:22:09 +08:00
Owner

The README also needs an update about using the satman target when building for a satellite.

The README also needs an update about using the satman target when building for a satellite.
mwojcik commented 2021-10-08 20:29:45 +08:00
Poster
Owner

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

find in the makefile is ran from artiq-zynq/src, and adds all files in src, including runtime and satman folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix.

Will update the README in a moment.

> > Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. > > Why is that an issue at all with phony targets? > Additionally, ``find`` should only look at the source directory, not the ``target`` directory. find in the makefile is ran from artiq-zynq/src, and adds all files in src, including ``runtime`` and ``satman`` folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix. Will update the README in a moment.
sb10q commented 2021-10-08 20:31:01 +08:00
Owner

find -type f ?

``find -type f`` ?
👍 1
sb10q commented 2021-10-08 20:31:43 +08:00
Owner

Directories should not have been included anyway.

Directories should not have been included anyway.
mwojcik added 1 commit 2021-10-08 20:37:17 +08:00
mwojcik added 1 commit 2021-10-08 20:38:55 +08:00
mwojcik added 1 commit 2021-10-08 20:45:59 +08:00
sb10q merged commit 219c075931 into master 2021-10-08 21:06:23 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical
   
priority:high
   
priority:low
   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#144
There is no content yet.
Delete Branch "mwojcik/artiq-zynq:make_explicit_targets"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?