added explicit runtime/satman targets for makefile #144

Merged
sb10q merged 4 commits from mwojcik/artiq-zynq:make_explicit_targets into master 1 year ago
mwojcik commented 1 year ago
Owner

As discussed in #135.

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

As discussed in #135. Unfortunately they cannot be called simply runtime/satman as it collides with what ``find`` finds.
mwojcik added 1 commit 1 year ago
Owner

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

> Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. Why is that an issue at all with phony targets? Additionally, ``find`` should only look at the source directory, not the ``target`` directory.
Owner

The README also needs an update about using the satman target when building for a satellite.

The README also needs an update about using the satman target when building for a satellite.
Poster
Owner

Unfortunately they cannot be called simply runtime/satman as it collides with what find finds.

Why is that an issue at all with phony targets?
Additionally, find should only look at the source directory, not the target directory.

find in the makefile is ran from artiq-zynq/src, and adds all files in src, including runtime and satman folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix.

Will update the README in a moment.

> > Unfortunately they cannot be called simply runtime/satman as it collides with what find finds. > > Why is that an issue at all with phony targets? > Additionally, ``find`` should only look at the source directory, not the ``target`` directory. find in the makefile is ran from artiq-zynq/src, and adds all files in src, including ``runtime`` and ``satman`` folders. Which would be targets too, causing circular dependency and building both firmwares at once. Even with phony targets it's an issue. So the workaround is not to use target names runtime and satman, hence the suffix. Will update the README in a moment.
Owner

find -type f ?

``find -type f`` ?
Owner

Directories should not have been included anyway.

Directories should not have been included anyway.
mwojcik added 1 commit 1 year ago
mwojcik added 1 commit 1 year ago
mwojcik added 1 commit 1 year ago
sb10q merged commit 219c075931 into master 1 year ago
The pull request has been merged as 219c075931.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.