M-Labs
/
artiq-zynq
9
1
Fork 16
Code Issues 14 Pull Requests 1 Releases Wiki Activity

misc runtime patch #103

Merged
sb10q merged 3 commits from pca006132/artiq-zynq:runtime into master 2020-09-02 10:15:52 +08:00
Conversation 0 Commits 3 Files Changed 7
pca006132 commented 2020-09-01 16:20:43 +08:00
There is no content yet.
sb10q reviewed 2020-09-01 16:36:31 +08:00
src/runtime/src/kernel/control.rs Outdated
@ -17,1 +18,4 @@
core0_tx = CHANNEL_0TO1.lock().take();
// prevent deadlock...
// the compiler optimized this routine so fast that it would deadlock
for _ in 0..100 {
sb10q commented 2020-09-01 16:36:31 +08:00
Owner

Are 100 nops actually needed? Why not 1?

Are 100 nops actually needed? Why not 1?
pca006132 commented 2020-09-01 16:53:53 +08:00
Poster

I just add the nops randomly, perhaps a smaller number would do.

I just add the nops randomly, perhaps a smaller number would do.
sb10q commented 2020-09-01 16:54:52 +08:00
Owner

If the problem is a compiler optimization, a single nop (without a for loop) should do, no?

If the problem is a compiler optimization, a single nop (without a for loop) should do, no?
pca006132 commented 2020-09-01 17:00:03 +08:00
Poster

The problem is not compiler optimization, we were having a race condition, and the compiler optimization just make it occur consistently. This fix would not fix the race condition, but provide better chance for core1 to get the mutex. In theory it can still deadlock, but very unlikely.

The problem is not compiler optimization, we were having a race condition, and the compiler optimization just make it occur consistently. This fix would not fix the race condition, but provide better chance for core1 to get the mutex. In theory it can still deadlock, but very unlikely.
sb10q closed this pull request 2020-09-02 10:15:52 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical
   
priority:high
   
priority:low
   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#103
There is no content yet.
Delete Branch "pca006132/artiq-zynq:runtime"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?