M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

Add ebaz4205 support #327

Merged
sb10q merged 7 commits from newell/artiq-zynq:ebaz4205 into master 2024-10-05 15:05:54 +08:00
Conversation 0 Commits 7 Files Changed 4 +262 -3
newell commented 2024-10-01 05:35:24 +08:00
Contributor
Copy Link

Add support to artiq-zynq for EBAZ4205.

Testing:

  • MonInj (LEDs, GPIO)
  • Experiments (LEDs, GPIO)
  • Analyzer (LEDs, not GPIO)

Note: artiq_coreanalyzer -p shows the GPIO toggling but I have not been able to get it to view in the waveform viewer of the dashboard.

Add support to `artiq-zynq` for `EBAZ4205`. Testing: - [x] MonInj (LEDs, GPIO) - [x] Experiments (LEDs, GPIO) - [x] Analyzer (LEDs, not GPIO) Note: `artiq_coreanalyzer -p` shows the GPIO toggling but I have not been able to get it to view in the waveform viewer of the dashboard.
newell added 4 commits 2024-10-01 05:35:24 +08:00
mwojcik reviewed 2024-10-01 10:26:28 +08:00
src/gateware/ebaz4205.py Outdated
@ -0,0 +87,4 @@
platform.add_extension(_ps)
platform.add_extension(_ddr)
## Uncomment if your EBAZ4205 doesn't have a PHY XTAL
mwojcik commented 2024-10-01 10:26:28 +08:00
Owner
Copy Link

This should be a commandline option (e.g. --no-xtal), rather than uncommenting

This should be a commandline option (e.g. ``--no-xtal``), rather than uncommenting
newell commented 2024-10-01 11:45:10 +08:00
Author
Contributor
Copy Link

Yes, agreed. This board is known to come in different variants on the 2nd hand market and I don't feel like removing the xtal to test things as my board has the xtal populated. I will remove this commented out code and leave the commandline option for a possible future branch.

Yes, agreed. This board is known to come in different variants on the 2nd hand market and I don't feel like removing the xtal to test things as my board has the xtal populated. I will remove this commented out code and leave the commandline option for a possible future branch.
mwojcik commented 2024-10-01 12:47:08 +08:00
Owner
Copy Link

Fair enough, don't add anything that's not been tested either.

Fair enough, don't add anything that's not been tested either.
newell marked this conversation as resolved
newell added 1 commit 2024-10-01 11:57:21 +08:00
newell changed title from Add ebaz4205 support to WIP: Add ebaz4205 support 2024-10-01 13:18:13 +08:00
newell changed title from WIP: Add ebaz4205 support to Add ebaz4205 support 2024-10-02 14:49:22 +08:00
sb10q reviewed 2024-10-02 20:01:15 +08:00
src/libksupport/src/kernel/api.rs Outdated
@ -115,2 +121,4 @@
api!(i2c_write = i2c::write),
#[cfg(not(feature = "target_ebaz4205"))]
api!(i2c_read = i2c::read),
#[cfg(not(feature = "target_ebaz4205"))]
sb10q commented 2024-10-02 20:01:15 +08:00
Owner
Copy Link

Might be simpler to either (1) add a dummy module with I2C functions that always return error/false, or (2) dedicate two I/O pins on the board to I2C since many use cases will want it anyway.

Might be simpler to either (1) add a dummy module with I2C functions that always return error/false, or (2) dedicate two I/O pins on the board to I2C since many use cases will want it anyway.
newell commented 2024-10-03 05:14:35 +08:00
Author
Contributor
Copy Link

I am open to either option. Note that if I did go with (2), dedicating two I/O pins, I would need to update zynq-rs for this as well. What do you deem the better option?

I am open to either option. Note that if I did go with (2), dedicating two I/O pins, I would need to update `zynq-rs` for this as well. What do you deem the better option?
mwojcik commented 2024-10-03 09:51:14 +08:00
Owner
Copy Link

Another zynq-rs update is not a problem, but if it's too contrived, you may go with dummies for now and add I2C support later.

Another ``zynq-rs`` update is not a problem, but if it's too contrived, you may go with dummies for now and add I2C support later.
newell marked this conversation as resolved
sb10q reviewed 2024-10-02 20:02:14 +08:00
src/gateware/ebaz4205.py Outdated
@ -0,0 +211,4 @@
parser.add_argument(
"-g", default=None, help="build gateware into the specified directory"
)
parser.add_argument("--rtio_clk", default=100e6, help="RTIO Clock Frequency (Hz)")
sb10q commented 2024-10-02 20:02:14 +08:00
Owner
Copy Link

125MHz would be a more sensible default.

125MHz would be a more sensible default.
👍 1
sb10q commented 2024-10-02 20:05:20 +08:00
Owner
Copy Link

And I think most other programs use - not _ in command line arguments.

And I think most other programs use - not _ in command line arguments.
👍 1
newell marked this conversation as resolved
newell added 1 commit 2024-10-05 14:45:40 +08:00
newell changed title from Add ebaz4205 support to WIP: Add ebaz4205 support 2024-10-05 14:48:17 +08:00
newell added 1 commit 2024-10-05 14:59:52 +08:00
newell changed title from WIP: Add ebaz4205 support to Add ebaz4205 support 2024-10-05 15:00:50 +08:00
sb10q referenced this issue from a commit 2024-10-05 15:05:51 +08:00
Add ebaz4205 support (#327)
sb10q merged commit 81790257a5 into master 2024-10-05 15:05:53 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#327
No description provided.
Delete Branch "newell/artiq-zynq:ebaz4205"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?