M-Labs
/
artiq-zynq
10
1
Fork 19
Code Issues 13 Pull Requests Releases Wiki Activity

review Si5324 setup code #208

New Issue
Closed
opened 2022-12-09 16:27:33 +08:00 by sb10q · 2 comments
sb10q commented 2022-12-09 16:27:33 +08:00
Owner
Copy Link

Zynq codebase might also need those fixes:
261dc6b933
740543d4e2
3c7a394eff

Zynq codebase might also need those fixes: https://github.com/m-labs/artiq/commit/261dc6b9330e831720bcb0de116fab4ece2c8bf4 https://github.com/m-labs/artiq/commit/740543d4e284245248e3ff838c46505938dcae7a https://github.com/m-labs/artiq/commit/3c7a394eff553ab75a7ea78bdd17830366504dc6
dpn was assigned by sb10q 2022-12-09 16:27:33 +08:00
dpn commented 2022-12-13 07:29:34 +08:00
Collaborator
Copy Link

261dc6b933 was apparently already fixed in artiq-zynq.

740543d4e2 was also fixed a different way; unified with the upstream ARTIQ solution in 5c054cc901 just to keep the implementations close. (Any long-term plan here, by the way?)

261dc6b933 was apparently already fixed in artiq-zynq. 740543d4e2 was also fixed a different way; unified with the upstream ARTIQ solution in https://git.m-labs.hk/M-Labs/artiq-zynq/commit/5c054cc90194b7647f78168b51bc452eed42f33e just to keep the implementations close. (Any long-term plan here, by the way?)
dpn closed this issue 2022-12-13 07:29:35 +08:00
sb10q commented 2022-12-13 09:54:00 +08:00
Author
Owner
Copy Link

We should merge the firmware code and put everything into the main ARTIQ repository at some point.

We should merge the firmware code and put everything into the main ARTIQ repository at some point.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
release-7
release-8
release-6
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#208
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?