M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

implement get_destination_status #177

Merged
sb10q merged 4 commits from mwojcik/artiq-zynq:rtio_destination_status into master 2022-03-25 18:20:05 +08:00
Conversation 0 Commits 4 Files Changed 6 +34 -18
mwojcik commented 2022-03-25 17:39:41 +08:00
Owner
Copy Link

As a small break from the axi stuff, I tackled the other issue from the original thread - get_destination_status not being implemented (being hardcoded to return true on destination == 0).

This one was just a bit tricky - yeah I used messages, but to use messages/channels freely, the code must be a part of the kernel submodule in runtime, since channels are not public statics and I would rather keep them that way. So that was moved there. Not sure if this could be condensed nicely somewhere else, instead of making a new module.

Tested on Kasli-SoC master with connected Kasli 1.1 satellite. The function in experiments (in Python) does behave as intended.

As a small break from the axi stuff, I tackled the other issue from the original thread - get_destination_status not being implemented (being hardcoded to return true on destination == 0). This one was just a bit tricky - yeah I used messages, but to use messages/channels freely, the code must be a part of the ``kernel`` submodule in runtime, since channels are not public ``statics`` and I would rather keep them that way. So that was moved there. Not sure if this could be condensed nicely somewhere else, instead of making a new module. Tested on Kasli-SoC master with connected Kasli 1.1 satellite. The function in experiments (in Python) does behave as intended.
mwojcik added 2 commits 2022-03-25 17:39:41 +08:00
sb10q reviewed 2022-03-25 17:43:11 +08:00
src/runtime/src/kernel/rtio.rs Outdated
@ -0,0 +1,19 @@
use super::{KERNEL_CHANNEL_0TO1, KERNEL_CHANNEL_1TO0, Message};
pub extern fn get_destination_status(destination: i32) -> bool {
sb10q commented 2022-03-25 17:43:11 +08:00
Owner
Copy Link

It's just one small function, what about just putting it in src/kernel/core1.rs?

It's just one small function, what about just putting it in ``src/kernel/core1.rs``?
mwojcik added 1 commit 2022-03-25 17:50:31 +08:00
sb10q reviewed 2022-03-25 17:51:50 +08:00
src/runtime/src/kernel/api.rs Outdated
@ -14,3 +14,3 @@
use super::dma;
use super::cache;
use super::core1::get_destination_status;
sb10q commented 2022-03-25 17:51:50 +08:00
Owner
Copy Link

Keep the rtio_ prefix?

Keep the rtio_ prefix?
mwojcik added 1 commit 2022-03-25 17:55:18 +08:00
sb10q merged commit a92561b9d3 into master 2022-03-25 18:20:05 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#177
No description provided.
Delete Branch "mwojcik/artiq-zynq:rtio_destination_status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?