M-Labs/artiq-zynq
10
1
Fork 19
Code Issues 12 Pull Requests Releases Wiki Activity

expose pca954x_select api #167

Merged
sb10q merged 4 commits from mwojcik/artiq-zynq:pca954x_select_api into master 2022-03-02 10:52:27 +08:00
Conversation 2 Commits 4 Files Changed 4 +55
mwojcik commented 2022-02-28 17:09:02 +08:00
Owner
Copy Link

PR accompanying to ARTIQ's PCA954X support (#1860).

Needs more testing still. Doesn't seem to work (testing on a crate with Urukuls, getting PLL lock timeout even after changing), and not sure if it's because of Urukul cards or something else.

PR accompanying to ARTIQ's PCA954X support (#1860). Needs more testing still. Doesn't seem to work (testing on a crate with Urukuls, getting PLL lock timeout even after changing), and not sure if it's because of Urukul cards or something else.
mwojcik added 1 commit 2022-02-28 17:09:03 +08:00
sb10q commented 2022-02-28 17:12:46 +08:00
Owner
Copy Link

Urukul PLLs don't have to do with I2C.

Urukul PLLs don't have to do with I2C.
mwojcik commented 2022-02-28 17:14:52 +08:00
Author
Owner
Copy Link

Oh. Yeah, true, it's only for the EEPROMs for syncing.

...then certainly more checks are necessary, until I can really confirm it working.

Oh. Yeah, true, it's only for the EEPROMs for syncing. ...then certainly more checks are necessary, until I can really confirm it working.
mwojcik added 1 commit 2022-03-01 14:52:36 +08:00
sb10q reviewed 2022-03-01 18:20:15 +08:00
src/runtime/src/i2c.rs Outdated
@ -63,0 +75,4 @@
0x20 => Some(5),
0x40 => Some(6),
0x80 => Some(7),
_ => { artiq_raise!("I2CError", "switch select supports only one channel"); return }
sb10q commented 2022-03-01 18:20:15 +08:00
Owner
Copy Link

return is not needed I think?

return is not needed I think?
sb10q reviewed 2022-03-01 18:20:49 +08:00
src/runtime/src/i2c.rs Outdated
@ -63,0 +64,4 @@
if busno > 0 {
artiq_raise!("I2CError", "I2C bus could not be accessed");
}
unsafe {
sb10q commented 2022-03-01 18:20:49 +08:00
Owner
Copy Link

At least the match statement does not need to be in unsafe.

At least the match statement does not need to be in unsafe.
mwojcik added 1 commit 2022-03-02 10:03:17 +08:00
mwojcik added 1 commit 2022-03-02 10:49:28 +08:00
mwojcik changed title from [wip] expose pca954x_select api to expose pca954x_select api 2022-03-02 10:51:56 +08:00
sb10q merged commit 9a06cd9d27 into master 2022-03-02 10:52:27 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical

   
priority:high

   
priority:low

   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#167
No description provided.
Delete Branch "mwojcik/artiq-zynq:pca954x_select_api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?