no_mangle compiler warnings #115

New Issue

sb10q · 2020-11-06T12:20:35+08:00

sb10q commented

2020-11-06 12:20:35 +08:00

warning: attribute should be applied to a function or static
  --> runtime/src/kernel/core1.rs:32:5
   |
32 |     #[no_mangle]
   |     ^^^^^^^^^^^^
33 |     static __text_start: u32;
   |     ------------------------- not a function or static
   |
   = note: `#[warn(unused_attributes)]` on by default
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

warning: attribute should be applied to a function or static
  --> runtime/src/kernel/core1.rs:34:5
   |
34 |     #[no_mangle]
   |     ^^^^^^^^^^^^
35 |     static __text_end: u32;
   |     ----------------------- not a function or static
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

warning: attribute should be applied to a function or static
  --> runtime/src/kernel/core1.rs:36:5
   |
36 |     #[no_mangle]
   |     ^^^^^^^^^^^^
37 |     static __exidx_start: u32;
   |     -------------------------- not a function or static
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

warning: attribute should be applied to a function or static
  --> runtime/src/kernel/core1.rs:38:5
   |
38 |     #[no_mangle]
   |     ^^^^^^^^^^^^
39 |     static __exidx_end: u32;
   |     ------------------------ not a function or static
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

```text warning: attribute should be applied to a function or static --> runtime/src/kernel/core1.rs:32:5 | 32 | #[no_mangle] | ^^^^^^^^^^^^ 33 | static __text_start: u32; | ------------------------- not a function or static | = note: `#[warn(unused_attributes)]` on by default = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! warning: attribute should be applied to a function or static --> runtime/src/kernel/core1.rs:34:5 | 34 | #[no_mangle] | ^^^^^^^^^^^^ 35 | static __text_end: u32; | ----------------------- not a function or static | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! warning: attribute should be applied to a function or static --> runtime/src/kernel/core1.rs:36:5 | 36 | #[no_mangle] | ^^^^^^^^^^^^ 37 | static __exidx_start: u32; | -------------------------- not a function or static | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! warning: attribute should be applied to a function or static --> runtime/src/kernel/core1.rs:38:5 | 38 | #[no_mangle] | ^^^^^^^^^^^^ 39 | static __exidx_end: u32; | ------------------------ not a function or static | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! ```

dpn commented

2020-11-12 19:45:12 +08:00

The error message is pretty bad, as they are in fact marked static – at first glance, it isn't clear to me that this isn't a compiler bug. Perhaps the extern "C" throws it off?

pca006132 commented

2020-11-12 23:49:33 +08:00

The error message is pretty bad, as they are in fact marked static – at first glance, it isn't clear to me that this isn't a compiler bug. Perhaps the extern "C" throws it off?

Just opened an issue: https://github.com/rust-lang/rust/issues/78989

> The error message is pretty bad, as they are in fact marked static – at first glance, it isn't clear to me that this isn't a compiler bug. Perhaps the extern "C" throws it off? Just opened an issue: https://github.com/rust-lang/rust/issues/78989

sb10q referenced this issue from a commit

2020-11-16 14:57:22 +08:00

remove unnecessary no_mangle no_mangle does nothing on extern items as per https://github.com/rust-lang/rust/issues/78989#issuecomment-726163973 Closes #115

sb10q closed this issue

2020-11-16 14:57:22 +08:00

Sign in to join this conversation.