M-Labs/artiq-extrapkg
2
0
Fork 4
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

Backport: remove scipy dependency for MSYS2 ARTIQ #20

Merged
sb10q merged 1 commits from fsagbuya/artiq-extrapkg:omit_scipy_8 into release-8 2024-08-17 17:37:24 +08:00
Conversation 3 Commits 1 Files Changed 2 +22 -28
fsagbuya commented 2024-07-26 20:34:14 +08:00
Contributor
Copy Link

Description

Remove scipy because the package breaks with a recent update:

error: target not found: mingw-w64-clang-x86_64-python-scipy
Breaking commit: a79dca42f1

Temporary fix for https://github.com/m-labs/artiq/issues/2512.

Tests:

  • artiq_master and artiq_dashboard (v.8.8892+86a8d2d) execution using MSYS2 offline installer.
  • python -m unittest discover -v artiq.test
  • artiq_compile against Kasli.
### Description Remove `scipy` because the package breaks with a recent update: ``` error: target not found: mingw-w64-clang-x86_64-python-scipy Breaking commit: a79dca42f1 ``` Temporary fix for https://github.com/m-labs/artiq/issues/2512. **Tests:** - `artiq_master` and `artiq_dashboard` (v.8.8892+86a8d2d) execution using MSYS2 offline installer. - `python -m unittest discover -v artiq.test` - `artiq_compile` against Kasli.
fsagbuya added 2 commits 2024-07-26 20:34:14 +08:00
sb10q commented 2024-07-26 22:39:23 +08:00
Owner
Copy Link

Please test artiq_compile as well, the LLVM/llvmlite stuff often tends to break.

Please test artiq_compile as well, the LLVM/llvmlite stuff often tends to break.
fsagbuya commented 2024-07-27 11:36:56 +08:00
Author
Contributor
Copy Link

Please test artiq_compile as well, the LLVM/llvmlite stuff often tends to break.

Tested artiq_compile with experiments in the examples directory. It compiles without any errors. However, I noticed that it's already targeting llvm-18, since we used the namespace llvm and not llvm-15 (which is used in the Linux version of ARTIQ). Should we keep it this way?

> Please test artiq_compile as well, the LLVM/llvmlite stuff often tends to break. Tested `artiq_compile` with experiments in the `examples` directory. It compiles without any errors. However, I noticed that it's already targeting [llvm-18](https://git.m-labs.hk/M-Labs/artiq-extrapkg/src/branch/master/msys2/artiq_dependency_packages.nix#L496), since we used the namespace [llvm ](https://git.m-labs.hk/M-Labs/artiq-extrapkg/src/branch/master/msys2/artiq_dependencies.txt#L17) and not [llvm-15](https://packages.msys2.org/base/mingw-w64-llvm-15) (which is used in the Linux version of ARTIQ). Should we keep it this way?
sb10q commented 2024-07-27 14:56:42 +08:00
Owner
Copy Link

Probably doesn't matter too much since we are just using the machine code tools of LLVM (addr2line, lld, etc.) and unlike the others they tend not to break compatibility every few days there.

llvmlite is statically linked against LLVM 15 and does not use the other llvm packages for code generation.

Probably doesn't matter too much since we are just using the machine code tools of LLVM (addr2line, lld, etc.) and unlike the others they tend not to break compatibility every few days there. llvmlite is statically linked against LLVM 15 and does not use the other llvm packages for code generation.
sb10q merged commit 763df7d869 into release-8 2024-07-27 21:43:46 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-extrapkg#20
No description provided.
Delete Branch "fsagbuya/artiq-extrapkg:omit_scipy_8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?