M-Labs
/
artiq-extrapkg
2
0
Fork 4
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

Remove scipy dependency for MSYS2 ARTIQ #19

Merged
sb10q merged 1 commits from fsagbuya/artiq-extrapkg:omit_scipy into master 2024-08-17 17:37:24 +08:00
Conversation 3 Commits 1 Files Changed 2 +22 -28
fsagbuya commented 2024-07-24 14:59:12 +08:00
Contributor
Copy Link

Description

Remove scipy because the package breaks with a recent update:

error: target not found: mingw-w64-clang-x86_64-python-scipy

Breaking commit: a79dca42f1

Temporary fix for https://github.com/m-labs/artiq/issues/2512.

Tests:

  • artiq_master and artiq_dashboard (v9.8902+c2e3236.beta) execution using MSYS2 offline installer.
  • python -m unittest discover -v artiq.test
  • artiq_compile against Kasli.
### Description Remove `scipy` because the package breaks with a recent update: ``` error: target not found: mingw-w64-clang-x86_64-python-scipy ``` Breaking commit: https://github.com/msys2/MINGW-packages/pull/21416/commits/a79dca42f16b77901240bdd8f20c4906771b4201 Temporary fix for https://github.com/m-labs/artiq/issues/2512. **Tests:** - `artiq_master` and `artiq_dashboard` (v9.8902+c2e3236.beta) execution using MSYS2 offline installer. - `python -m unittest discover -v artiq.test` - `artiq_compile` against Kasli.
fsagbuya added 2 commits 2024-07-24 14:59:12 +08:00
sb10q commented 2024-07-25 08:09:46 +08:00
Owner
Copy Link

What tests were done?

What tests were done?
fsagbuya commented 2024-07-25 12:15:03 +08:00
Author
Contributor
Copy Link

What tests were done?

Tested with theMSYS2 with ARTIQ offline installer. Both master and dashboard can be executed. The primary difference is that the experiment Flopping F simulation which depends on scipy, is not visible from the dashboard. When run manually, it returns:

root:Terminating with exception (ModuleNotFoundError: No module named 'scipy')

Which is the expected behavior.

> What tests were done? Tested with the`MSYS2 with ARTIQ` offline installer. Both master and dashboard can be executed. The primary difference is that the experiment `Flopping F simulation` which depends on `scipy`, is not visible from the dashboard. When run manually, it returns: ``` root:Terminating with exception (ModuleNotFoundError: No module named 'scipy') ``` Which is the expected behavior.
sb10q commented 2024-07-25 20:52:46 +08:00
Owner
Copy Link

Needs backport and testing on release-8.

Needs backport and testing on release-8.
👍 1
sb10q merged commit 5b4560d8ca into master 2024-07-27 21:40:38 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-extrapkg#19
No description provided.
Delete Branch "fsagbuya/artiq-extrapkg:omit_scipy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?